Drop 12.4 support #521
Merged
Drop 12.4 support #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
commented
Feb 26, 2025
| 1. Install Pytorch corresponding to your CUDA Toolkit using the | ||
| [official instructions](https://pytorch.org/get-started/locally/). You'll | ||
| need the `libnpp` and `libnvrtc` CUDA libraries, which are usually part of | ||
| the CUDA Toolkit. |
Contributor
Author
There was a problem hiding this comment.
I removed the previously-first entry, because I don't think we should be in the business of telling people how to install the CUDA toolkit. We were just saying "you should install it" without providing any guidance, so it wasn't that useful anyway.
And I fear it may raise the barrier. In the majority of cases, users who have a working pytorch installation with cuda won't need to do anything special, because all the necessary libraries are already installed.
scotts
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pytorch/pytorch#145544 and https://fburl.com/workplace/sqyr6fci (internal link).