[torchcodec] delay device map init to runtime and fix targets #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72722867 |
…ytorch#631) Summary: Pull Request resolved: meta-pytorch#631 We were running into the Static Initialization Order Fiasco: https://en.cppreference.com/w/cpp/language/siof We avoid this problem by delaying the initialization of the device map until runtime. Differential Revision: D72722867
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72722867 |
facebook-github-bot
merged commit 619f1ce
into
meta-pytorch:main
46 of 48 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We were running into the Static Initialization Order Fiasco: https://en.cppreference.com/w/cpp/language/siof
We avoid this problem by delaying the initialization of the device map until runtime.
Differential Revision: D72722867