-
Notifications
You must be signed in to change notification settings - Fork 50
Policy uses the generic completion data model #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ritesh1905
commented
Sep 22, 2025
- Policy uses the generic completion data model
- Ran all the apps using the vLLm specific output
Ritesh1905
commented
Sep 22, 2025
joecummings
reviewed
Sep 22, 2025
Jack-Khuu
approved these changes
Sep 22, 2025
vidhyav
reviewed
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
* using the completions data model * working changes * few mode fixes * lints * review comments --------- Co-authored-by: rithesh <rithesh@devgpu001.lla1.facebook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.