Skip to content

Update torchtitan for proper bf16 & new quant APIs #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2025
Merged

Update torchtitan for proper bf16 & new quant APIs #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00ce572
Update torchtitan for proper bf16 & new quant APIs
joecummings Oct 1, 2025
1dcf00a
Merge remote-tracking branch 'upstream/main' into update-torchtitan-f…
joecummings Oct 1, 2025
b42a756
Update num tokens back to 512
joecummings Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/grpo/qwen3_8b.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
# Global configuration
group_size: 8
batch_size: 16
max_req_tokens: 468
max_res_tokens: 468
max_req_tokens: 512
max_res_tokens: 512
model: "Qwen/Qwen3-8B"
off_by_n: 1 # Off by one by default

Expand Down
Binary file modified assets/wheels/torchtitan-0.1.0-py3-none-any.whl
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion scripts/build_wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ NC='\033[0m'
PYTORCH_VERSION="2.9.0.dev20250905"
VLLM_BRANCH="v0.10.0"
MONARCH_COMMIT="9c41b5c16edadeab7cfb8521ba7efe68a1e2bc87"
TORCHTITAN_COMMIT="a3104201ba3a0fa19e9c3cc5ba748b0398551410"
TORCHTITAN_COMMIT="9f3fe08635356b829e6bf41883760679a8207697"
TORCHSTORE_COMMIT="0052f6d8b686b9cff0cf4ce203a836c4b5d5ac94"
BUILD_DIR="$HOME/forge-build"
WHEEL_DIR="$(pwd)/assets/wheels"
Expand Down
4 changes: 2 additions & 2 deletions src/forge/actors/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
Checkpoint,
Comm,
Compile,
Float8Dense,
Float8Linear,
LRScheduler,
Model,
Optimizer,
Expand Down Expand Up @@ -104,7 +104,7 @@ class RLTrainer(ForgeActor):
)
use_vllm_builtin_load: bool = True
compile: Compile = field(default_factory=Compile)
float8: Float8Dense = field(default_factory=Float8Dense)
Copy link
Member Author

@joecummings joecummings Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also a part of the updated Torchtitan package

float8: Float8Linear = field(default_factory=Float8Linear)
comm: Comm = field(default_factory=Comm)
loss: Callable = lambda logits, **targets: logits
state_dict_key: str = "model_state_dict"
Expand Down
Loading