Skip to content

Conversation

@joecummings
Copy link
Member

No description provided.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 2, 2025
Comment on lines 13 to 14
Describe the problem you're trying to solve or the use case for this feature.
What is the motivation behind this request? Why would this feature be valuable?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine to keep as is, but i think it could be a one liner

required: true
- type: textarea
attributes:
label: 💡 What does this look like in pseudo-code?
Copy link
Contributor

@felipemello1 felipemello1 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if i like this. The intention is good, but maybe too much overhead? e.g. someone requesting multiturn or LoRA. Do they need to come up with a design? Perhaps we could reword to something like "Share any examples or pseudo-code if you have it"

required: false
- type: textarea
attributes:
label: ✅ Acceptance Criteria
Copy link
Contributor

@felipemello1 felipemello1 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, intention is good, but it feels like a bit too much overhead. How would an user fill this with "request for LoRA" or "request for multiturn"?

Copy link
Contributor

@felipemello1 felipemello1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still a bit skeptical about the complexity of the template, but lets merge it. Please try create a couple of dummy issues as if you were an user. If it feels like a nice experience, we keep it as is, otherwise we see what we can remove/simplify

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.23%. Comparing base (5bfcfae) to head (fe8cc76).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
- Coverage   84.10%   83.23%   -0.88%     
==========================================
  Files          29       31       +2     
  Lines        3687     3954     +267     
==========================================
+ Hits         3101     3291     +190     
- Misses        586      663      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joecummings joecummings merged commit b17bfeb into meta-pytorch:main Dec 3, 2025
10 checks passed
@joecummings joecummings deleted the add-issue-template branch December 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants