skip consistent hash test in OSS #3367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: # context * previous test failed due to `invalid device pointer` while an embedding module (EBC/EC) is created on `cuda:0`, and then the multiprocess forks the test into two threads to enable multi-GPU env. * the issue comes from the test case breakdown, where the same tenor is freed twice (likely) * here we modify the test case so that the embedding modules are created after the fork. Reviewed By: iamzainhuda Differential Revision: D82009423
Summary: # context * the proposal order might vary on different rank in [github action](https://github.com/pytorch/torchrec/actions/runs/17589918113/job/49967902728?fbclid=IwY2xjawMtaPxleHRuA2FlbQIxMQABHqSimhEWaKNU_G5SH_R2nioBbN7otIqoM1RDmlcjIZwB37M0cNWPEiOERRv1_aem_bhDL2MD4niEtgGMZrytbJQ) * skip this test * error log: P1939004930 Differential Revision: D82031515
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D82031515 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Sep 9, 2025
Summary: # context * the proposal order might vary on different rank in [github action](https://github.com/pytorch/torchrec/actions/runs/17589918113/job/49967902728?fbclid=IwY2xjawMtaPxleHRuA2FlbQIxMQABHqSimhEWaKNU_G5SH_R2nioBbN7otIqoM1RDmlcjIZwB37M0cNWPEiOERRv1_aem_bhDL2MD4niEtgGMZrytbJQ) * skip this test * error log: P1939004930 * order [comparison](https://www.internalfb.com/intern/diffing/?paste_number=1939241286) {F1981848607, width=300} * ref: D76303748 Reviewed By: aporialiao Differential Revision: D82031515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
Differential Revision: D82031515