(torchx/runner) Implement scheduler runopt dumping and loading to/from .INI file #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31601700 |
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 91.26% 91.55% +0.29%
==========================================
Files 58 60 +2
Lines 2667 2760 +93
==========================================
+ Hits 2434 2527 +93
Misses 233 233
Continue to review full report at Codecov.
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31601700 |
facebook-github-bot
added
the
CLA Signed
…m .INI file (#249) Summary: Pull Request resolved: #249 Implements `dumps` and `loads` functions that dumps and loads INI file containing the runopts for all registered schedulers. Here's a sample config file dumped by calling `torchx.runner.config.dumps(std.out)` ``` [default.local] log_dir = None prepend_cwd = False image_type = dir root_dir = /var/cache/fbpkg [default.local_cwd] log_dir = None prepend_cwd = False [default.local_par] log_dir = None prepend_cwd = False [default.local_fbpkg] log_dir = None prepend_cwd = False [default.mast] hpcClusterUuid = TSCTestCluster hpcEntitlementName = None runningTimeoutSec = None hpcIdentity = <FIXME_WITH_A_str_VALUE> hpcJobOncall = pyper_training useStrictName = False mounts = None localityConstraints = None enableGracefulPreemption = False [default.flow] secure_group = <FIXME_WITH_A_str_VALUE> entitlement = default proxy_workflow_image = None [default.quickflow] entitlement = default runningTimeoutSec = None identity = <FIXME_WITH_A_str_VALUE> oncall = None useStrictName = False mounts = None localityConstraints = None enableGracefulPreemption = False perpetualRun = False [default.slurm] partition = None time = None [default.kubernetes] namespace = default queue = <FIXME_WITH_A_str_VALUE> ``` Added a `//torchx/fb/example/.torchxconfig` . Next steps: document all this (will do this in a separate diff since its somewhat urgent we ship the functionality first) Reviewed By: aivanou Differential Revision: D31601700 fbshipit-source-id: 03461b376452ae80939b29b72ab240c43419d29e
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31601700 |
Contributor
|
This pull request has been merged in 431c0e2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implements
dumpsandloadsfunctions that dumps and loads INI file containing the runopts for all registered schedulers.Here's a sample config file dumped by calling
torchx.runner.config.dumps(std.out)Added a
//torchx/fb/example/.torchxconfig.Next steps: document all this (will do this in a separate diff since its somewhat urgent we ship the functionality first)
Differential Revision: D31601700