Add interpret docs to example component, remove test arg from cv tr…
#255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aivanou has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@aivanou has updated the pull request. You must reimport the pull request before landing. |
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
==========================================
+ Coverage 91.56% 91.61% +0.05%
==========================================
Files 60 60
Lines 2762 2767 +5
==========================================
+ Hits 2529 2535 +6
+ Misses 233 232 -1
Continue to review full report at Codecov.
|
|
@aivanou has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
… runcfg (#252) Summary: Pull Request resolved: #252 closes: #250 I've done a few things on this diff: 1. Renamed `torchx.specs.api.Runopt` to `torchx.specs.runopt` (for consistency with `runopts`) 2. Renamed variables (where I could) `runcfg` to `cfg` (to be consistent with the scheduler and runner apis) 3. Renamed the config section to `[$profile.$sched.cfg]` instead of `[$profile.scheduler_args.$sched]` 4. Changed the torchx run cli's `-a` (short for `--scheduler_args`) to `-cfg` for consistency with the rest of the system. Reviewed By: aivanou Differential Revision: D31656766 fbshipit-source-id: 8c009852d5807010ac4cd33902b294cff4bd0ec1
Summary: closes: #251 Reviewed By: d4l3k Differential Revision: D31659813 fbshipit-source-id: 150ea152339adf84d19f1eb8b4a2e083901705ab
|
@aivanou has updated the pull request. You must reimport the pull request before landing. |
|
@aivanou has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: This switches our integration tests to use the GitHub OpenID Connect credentials provider instead of using hard coded AWS session tokens. This will issue tokens that last for 1 hour so should be a lot more secure (and trackable) than before. https://awsteele.com/blog/2021/09/15/aws-federation-comes-to-github-actions.html Pull Request resolved: #256 Test Plan: CI created PR from external repo to verify they can't generate tokens #257 Reviewed By: kiukchung Differential Revision: D31674489 Pulled By: d4l3k fbshipit-source-id: 5936c64794816eb9fafe76899af44e2f865c64df
Summary: Since we removed distributed sum, we need to use this example to run fb internal tests. For internal tests, we don't need the `output_path`, which introduces around ~200 mb of data on each run Reviewed By: kiukchung Differential Revision: D31661378 fbshipit-source-id: 098bf9f5be9302e7d8cced672ba9cf7eaf8b32e6
Summary: Pull Request resolved: #258 Do not check `torchx.components.base` module for components Reviewed By: kiukchung Differential Revision: D31664832 fbshipit-source-id: 3de72047810ff8c2478e036ce5626459d4c073af
…al loading, and move config loading to cli from runner (#260) Summary: Pull Request resolved: #260 1. Removes profiles from .torchxconfig (also removes .cfg suffix from section) 2. Removes hierarchical loading (only picks up .torchxconfig from CWD - project dir) 3. Removes config application from runner and moves it to CLI only Reviewed By: d4l3k Differential Revision: D31674537 fbshipit-source-id: 937c3375771316b2bf2f1d65a560d7311031d4fa
Summary: This adds the missing `pandoc` dependency to the docpush CI step. Pull Request resolved: #264 Test Plan: Test with docpush manually enabled on the PR https://github.com/pytorch/torchx/pull/264/checks?check_run_id=3908761230 Reviewed By: aivanou Differential Revision: D31692193 Pulled By: d4l3k fbshipit-source-id: 0fcb9b5667ec096d458d4e293c0cd1b34d402f7d
…265) Summary: This switches the integration tests to use ec2 instance connect w/ an assumed role instead of embedding the slurm ssh key in GitHub secrets. Pull Request resolved: #265 Test Plan: ``` $ env SLURM_INSTANCE_MASTER=ubuntu@i-01dd4b95724eb0b4b scripts/slurmint.sh ``` CI Reviewed By: kiukchung, aivanou Differential Revision: D31695261 Pulled By: d4l3k fbshipit-source-id: 48a52e911e68bc9b18ed470a5f7e725ff58697b1
…x into aivanou_add_interpret_docs
|
@aivanou has updated the pull request. You must reimport the pull request before landing. |
|
@aivanou has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ainer
Test plan: