(torchx/docs) fix invalid references to docker when running with local_cwd in the components.dist docstring #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31828767 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31828767 |
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 94.71% 94.71%
=======================================
Files 56 56
Lines 2670 2670
=======================================
Hits 2529 2529
Misses 141 141
Continue to review full report at Codecov.
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31828767 |
…l_cwd in the components.dist docstring (#294) Summary: Pull Request resolved: #294 Fixes incorrect docs that claim to run on docker containers when the command is `-s local_cwd` (see screenshot below) {F672188530} Differential Revision: D31828767 fbshipit-source-id: 3806997023f463a11ae1bb8ff9824b660f297abe
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31828767 |
Contributor
|
This pull request has been merged in ddcae5c. |
grievejia
added a commit
to grievejia/torchx
that referenced
this pull request
Apr 18, 2022
…mantic changes (meta-pytorch#294) Summary: X-link: facebookresearch/fbpcp#294 X-link: facebookresearch/recipes#19 Pyre is going to have a semantic change in its configuration: D35695552. Basically, we are changing the default behavior on how search paths are discovered. Pre-existing configurations need to explicitly opt-in to the old behavior -- otherwise, they may risk breaking their type check setups. The added option will lead to a Pyre warning for now, but that warning would go away on the next Pyre upgrade. Reviewed By: stroxler Differential Revision: D35724336 fbshipit-source-id: d94f10d68589b1c176e0e8cf7df87ba3f2db9ef2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes incorrect docs that claim to run on docker containers when the command is
-s local_cwd(see screenshot below){F672188530}
Differential Revision: D31828767