slurmint: made the script more robust to different system configurations #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 65 65
Lines 3932 3932
=======================================
Hits 3727 3727
Misses 205 205 Continue to review full report at Codecov.
|
priyaramani
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the slurmint script to be more robust to environment changes since we switched to a new slurm cluster.
It removes the hardcoded
/home/ubuntuand uses venv provided by miniconda so we don't need virtualenv installed on the host.See https://www.internalfb.com/intern/wiki/PyTorch_R2P/Development/Slurm/ for more information
Test plan: