Skip to content

Conversation

@kurman
Copy link
Contributor

@kurman kurman commented Jun 15, 2022

0.2.0 Release

Test plan:
python -m unittest discover --verbose --start-directory . --pattern "*_test.py"

Validated main branch state in CI.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2022
@facebook-github-bot
Copy link
Contributor

@kurman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #518 (49db794) into main (84158cf) will decrease coverage by 2.40%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   94.78%   92.38%   -2.41%     
==========================================
  Files          65       65              
  Lines        3932     3925       -7     
==========================================
- Hits         3727     3626     -101     
- Misses        205      299      +94     
Impacted Files Coverage Δ
torchx/version.py 100.00% <100.00%> (ø)
torchx/schedulers/docker_scheduler.py 57.21% <0.00%> (-38.66%) ⬇️
torchx/workspace/docker_workspace.py 80.45% <0.00%> (-11.50%) ⬇️
torchx/util/entrypoints.py 90.00% <0.00%> (-10.00%) ⬇️
torchx/components/dist.py 86.04% <0.00%> (-2.33%) ⬇️
torchx/specs/file_linter.py 96.50% <0.00%> (-2.10%) ⬇️
torchx/schedulers/ray_scheduler.py 94.66% <0.00%> (-1.34%) ⬇️
torchx/schedulers/aws_batch_scheduler.py 88.20% <0.00%> (-0.06%) ⬇️
torchx/apps/utils/process_monitor.py 98.33% <0.00%> (-0.06%) ⬇️
torchx/schedulers/local_scheduler.py 93.03% <0.00%> (-0.04%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84158cf...49db794. Read the comment docs.

Remove unnecessary header tab
@facebook-github-bot
Copy link
Contributor

@kurman has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@kurman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Addressing comments
@facebook-github-bot
Copy link
Contributor

@kurman has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@kurman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kurman kurman merged commit 9016e10 into main Jun 15, 2022
@kurman kurman deleted the kurman-dev branch June 15, 2022 19:00
kurman added a commit that referenced this pull request Jun 15, 2022
d4l3k added a commit that referenced this pull request Jun 15, 2022
This reverts commit 9016e10.

Co-authored-by: kurman <74940256+kurman@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37161106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants