Skip to content

[Feature]Variable loc info PR3: Add frontend UI support for location alias visualization #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Feature]Variable loc info PR3: Add frontend UI support for location alias visualization #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions website/src/components/CodeViewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/* Location definition line styles */
.loc-definition-line {
background-color: rgba(255, 215, 0, 0.1) !important;
border-left: 3px solid #ffd700 !important;
}

.loc-definition-line:hover {
background-color: rgba(255, 215, 0, 0.2) !important;
}

/* Alias name badge */
.alias-badge {
display: inline-block;
margin-left: 8px;
padding: 2px 6px;
background: #e3f2fd;
border-radius: 3px;
font-size: 0.85em;
color: #1976d2;
font-weight: 500;
vertical-align: middle;
}

.alias-badge:hover {
background: #bbdefb;
}

/* Dark theme adjustments */
[data-theme="dark"] .alias-badge {
background: #1565c0;
color: #e3f2fd;
}

[data-theme="dark"] .alias-badge:hover {
background: #1976d2;
}

/* Loc ID indicator */
.loc-id-indicator {
opacity: 0.6;
font-size: 0.8em;
margin-left: 4px;
}
68 changes: 65 additions & 3 deletions website/src/components/CodeViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
oneDark,
} from "react-syntax-highlighter/dist/esm/styles/prism";
import type { SourceMapping } from "../utils/dataLoader";
import "./CodeViewer.css";

// Import language support
import llvm from 'react-syntax-highlighter/dist/esm/languages/prism/llvm';
Expand Down Expand Up @@ -207,6 +208,7 @@ const BasicCodeViewer: React.FC<CodeViewerProps> = ({
highlightedLines = [],
onLineClick,
viewerId,
sourceMapping,
}) => {
const containerRef = useRef<HTMLDivElement>(null);
const lines = splitIntoLines(code);
Expand Down Expand Up @@ -239,6 +241,21 @@ const BasicCodeViewer: React.FC<CodeViewerProps> = ({
{lines.map((line, index) => {
const lineNumber = index + 1;
const isHighlighted = highlightedLines.includes(lineNumber);
const mapping = sourceMapping?.[lineNumber.toString()];
const isLocDef = mapping?.type === "loc_def" || mapping?.kind === "loc_def";

// Build tooltip text for loc definitions
let tooltipText = "";
if (isLocDef && mapping) {
tooltipText = `Location definition`;
if (mapping.alias_name) {
tooltipText += `: ${mapping.alias_name}`;
}
if (mapping.alias_of !== undefined) {
const targetKey = mapping.alias_of === "" ? "#loc" : `#loc${mapping.alias_of}`;
tooltipText += ` → ${targetKey}`;
}
}

return (
<div
Expand All @@ -255,7 +272,11 @@ const BasicCodeViewer: React.FC<CodeViewerProps> = ({
}}
onClick={() => handleLineClick(lineNumber)}
data-line-number={lineNumber}
className={isHighlighted ? 'highlighted-line' : ''}
className={`${isHighlighted ? 'highlighted-line' : ''} ${isLocDef ? 'loc-definition-line' : ''}`}
title={tooltipText}
data-loc-id={mapping?.loc_id}
data-alias-name={mapping?.alias_name}
data-loc-def={isLocDef ? "true" : undefined}
>
<span style={{
position: "absolute",
Expand Down Expand Up @@ -290,6 +311,7 @@ const LargeFileViewer: React.FC<CodeViewerProps> = ({
highlightedLines = [],
onLineClick,
viewerId,
sourceMapping,
}) => {
const containerRef = useRef<HTMLDivElement>(null);
const [visibleRange, setVisibleRange] = useState({ start: 0, end: 50 });
Expand Down Expand Up @@ -421,6 +443,8 @@ const LargeFileViewer: React.FC<CodeViewerProps> = ({
lineProps={(lineNumber) => {
// Adjust line number based on visible range
const actualLine = lineNumber + visibleRange.start;
const mapping = sourceMapping?.[actualLine.toString()];
const isLocDef = mapping?.type === "loc_def" || mapping?.kind === "loc_def";

// Create styles for the line
const style: React.CSSProperties = {
Expand All @@ -440,11 +464,28 @@ const LargeFileViewer: React.FC<CodeViewerProps> = ({

}

// Build tooltip text for loc definitions
let tooltipText = "";
if (isLocDef && mapping) {
tooltipText = `Location definition`;
if (mapping.alias_name) {
tooltipText += `: ${mapping.alias_name}`;
}
if (mapping.alias_of !== undefined) {
const targetKey = mapping.alias_of === "" ? "#loc" : `#loc${mapping.alias_of}`;
tooltipText += ` → ${targetKey}`;
}
}

return {
style,
onClick: () => handleLineClick(actualLine),
'data-line-number': actualLine,
className: isHighlighted ? 'highlighted-line' : '',
className: `${isHighlighted ? 'highlighted-line' : ''} ${isLocDef ? 'loc-definition-line' : ''}`,
title: tooltipText,
'data-loc-id': mapping?.loc_id,
'data-alias-name': mapping?.alias_name,
'data-loc-def': isLocDef ? "true" : undefined,
};
}}
customStyle={{
Expand Down Expand Up @@ -474,6 +515,7 @@ const StandardCodeViewer: React.FC<CodeViewerProps> = ({
highlightedLines = [],
onLineClick,
viewerId,
sourceMapping,
}) => {
const containerRef = useRef<HTMLDivElement>(null);

Expand Down Expand Up @@ -537,6 +579,22 @@ const StandardCodeViewer: React.FC<CodeViewerProps> = ({
wrapLines={true}
lineProps={(lineNumber) => {
const isHighlighted = highlightedLines.includes(lineNumber);
const mapping = sourceMapping?.[lineNumber.toString()];
const isLocDef = mapping?.type === "loc_def" || mapping?.kind === "loc_def";

// Build tooltip text for loc definitions
let tooltipText = "";
if (isLocDef && mapping) {
tooltipText = `Location definition`;
if (mapping.alias_name) {
tooltipText += `: ${mapping.alias_name}`;
}
if (mapping.alias_of !== undefined) {
const targetKey = mapping.alias_of === "" ? "#loc" : `#loc${mapping.alias_of}`;
tooltipText += ` → ${targetKey}`;
}
}

return {
style: {
backgroundColor: isHighlighted
Expand All @@ -549,7 +607,11 @@ const StandardCodeViewer: React.FC<CodeViewerProps> = ({
},
onClick: () => handleLineClick(lineNumber),
"data-line-number": lineNumber,
className: isHighlighted ? 'highlighted-line' : '',
className: `${isHighlighted ? 'highlighted-line' : ''} ${isLocDef ? 'loc-definition-line' : ''}`,
title: tooltipText,
"data-loc-id": mapping?.loc_id,
"data-alias-name": mapping?.alias_name,
"data-loc-def": isLocDef ? "true" : undefined,
};
}}
>
Expand Down
6 changes: 6 additions & 0 deletions website/src/utils/dataLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ export interface SourceMapping {
ttgir_lines?: number[]; // Array of corresponding TTGIR lines
llir_lines?: number[]; // Array of corresponding LLIR lines
amdgcn_lines?: number[]; // Array of corresponding AMDGCN lines
// New fields for location alias support
type?: string; // Type of mapping entry, e.g., "loc_def" for loc definition lines
kind?: string; // Deprecated alias for type, kept for backward compatibility
loc_id?: string; // The #loc identifier (e.g., "13" for #loc13)
alias_name?: string; // Name of the alias (e.g., "x_ptr" in #loc13 = loc("x_ptr"(#loc)))
alias_of?: string; // The target #loc this alias points to
}

/**
Expand Down