Fix ModuleNotFoundError for tritonparse.fb in atexit cleanup#374
Fix ModuleNotFoundError for tritonparse.fb in atexit cleanup#374zhudada0120 wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
|
Hi @zhudada0120! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hi @FindHao, PTAL. Thanks! |
FindHao
left a comment
There was a problem hiding this comment.
LGTM! thanks for capturing this
Summary
This PR fixes an OSS-only shutdown error in
TritonTraceHandler._cleanup().When
TRITONPARSE_TRACE_MANIFOLDis enabled, cleanup may try to import the fb-only uploader in OSS environments and printModuleNotFoundError: No module named 'tritonparse.fb'duringatexit, even though trace generation and parsing have already succeeded.related issue:#373
Changes
is_fbcodefromshared_vars_cleanup()behindis_fbcode()This keeps the existing internal upload behavior unchanged while skipping the fb-only uploader path in OSS.
Testing