Fix Tracking & 404 Banner#1153
Conversation
iethree
left a comment
There was a problem hiding this comment.
Instead of manually pulling the chrome in a PR, can this just be part of the build process for this repo? isn't that the whole point of shared chrome? so we don't have to sync code? it should just get pulled in from the single source of truth at build time.
|
@iethree it is a part of the build process (see Strangely enough, now that you pointed it out (and I see that the chrome is still part of the diff and not up-to-date or behind), I realized that the issue isn't pulling it on build, but that it's not being committed, so it just stays hanging as a dirty file in CI that never gets updated. Just pushed fix: also commit shared chrome which adds I also updated the PR description. |
Fixes GRO-460, GRO-472