Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login History tab not available for LDAP/Google logins #15558

Closed
flamber opened this issue Apr 10, 2021 · 0 comments · Fixed by #16676
Closed

Login History tab not available for LDAP/Google logins #15558

flamber opened this issue Apr 10, 2021 · 0 comments · Fixed by #16676
Assignees
@noahmoss
Labels
Administration/Auth Google Auth, LDAP, pw+email login .Frontend Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Milestone
0.40

Comments

@flamber
Copy link
Contributor

flamber commented Apr 10, 2021

Describe the bug
The new Login History tab available in Account settings (/user/edit_current) is not available for SSO logins (LDAP/Google).
Likely a side-effect of #14741, which was added to hide Password tab.

To Reproduce

  1. Login with LDAP or Google and go to ⚙️ > Account settings - does not have any tabs available
    image
  2. Login with password login (or SAML/JWT) and go to ⚙️ > Account settings
    image

Information about your Metabase Installation:
release-x.39.x commit 0c4a6be
@flamber flamber added Type:Bug Product defects Priority:P2 Average run of the mill bug Administration/Auth Google Auth, LDAP, pw+email login .Frontend labels Apr 10, 2021
@nemanjaglumac nemanjaglumac mentioned this issue May 19, 2021
Merged
nemanjaglumac added a commit that referenced this issue May 19, 2021
@nemanjaglumac
Add repro for #15558
1e92d05
nemanjaglumac added a commit that referenced this issue May 19, 2021
@nemanjaglumac
#15558 Repro: Login History tab not available for LDAP/Google logins (#…
fd6510f 
…16146)

* Abstract and reuse `mockProperty` function

* Add repro for #15558
@nemanjaglumac nemanjaglumac added the .Reproduced Issues reproduced in test (usually Cypress) label May 19, 2021
@noahmoss noahmoss self-assigned this Jun 16, 2021
@noahmoss noahmoss mentioned this issue Jun 18, 2021
Merged
@noahmoss noahmoss added this to the 0.40 milestone Jun 18, 2021
@deploysentinel deploysentinel bot mentioned this issue Dec 6, 2022
Merged
@deploysentinel deploysentinel bot mentioned this issue Dec 13, 2022
Merged
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced May 8, 2024
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahmoss noahmoss

Labels
Administration/Auth Google Auth, LDAP, pw+email login .Frontend Priority:P2 Average run of the mill bug .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
Cypress Testing
Awaiting triage
Milestone
0.40
Development

Successfully merging a pull request may close this issue.

Show login history tab for LDAP/Google auth logins metabase/metabase
3 participants
@flamber @nemanjaglumac @noahmoss