Conversation
We only want to read the TOC when no features are given explicitely.
This is available starting with libdiscid 0.3.0, but we only require 0.2.2 -> try-except. None is returned when it is not implemented or not requested.
ghost
assigned
Collaborator
Author
|
With the feature API from #20 we can now implement the ISRC / MCN api. Still not sure if that should go in 1.0.0 or not. |
That mapping is a good way to implement the feature enum of libdiscid and we can also use it to create FEATURES_IMPLEMENTED on the fly.
I removed the possibility to request all features (UINT_MAX) again. It would lead to weird behavior as phw stated. Features that wouldn't need additional changes in this module, other than adding the mapping should be rare and python-discid, would get added to this module fast anyways. It is more likely that libdiscid is older than python-discid since it is in stable repositories for Linux and needs new builds on other platforms.
Conflicts: discid.py doc/discid.rst
Otherwise we might indicate that ISRCs were read, when this is impossible with put(). The difference would only be "" vs. None, since the structure is reset in libdiscid for put().
Get the padding fix for when 1st track wouldn't be 1. (amended manually for track_isrcs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I won't do this in beta state, because this is only in libdiscid 0.3.0 (which is quite new) and there are still logical issues with that API.
There is no way yet to tell if the platform doesn't support ISRCs (with libdiscid) or there are no ISRCs on the disc.
See: http://tickets.musicbrainz.org/browse/LIB-23