Use features API from libdiscid#20
Merged
Merged
Conversation
ghost
assigned
To make sure we have a valid feature list, we do some checking in Python when the libdiscid API is not available, but ISRC/MCN API is.
JonnyJD
added a commit
that referenced
this pull request
Mar 11, 2013
Add a list of FEATURES implemented on the current platform. We build this list even if not given by libdiscid. See #20
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of LIB-23/libdiscid 0.4.0 there is an API to check if a certain feature is actually implemented on a platform.
Currently: read, mcn, isrc
For 1.0.0 we only have to check for read, but we expose the whole list anyways.
We should already give NotImplementedError when reading and the feature is not set.