reconsider track_offsets[0], track_lengths[0] etc.

[JonnyJD]

The decision to use track_offsets[1] to get the offset for the first track was based on discid_get_track_offset(disc, 1).

This is kind of an 1:1 translation to the libdiscid API, but when using an array tracks we have this:
tracks[0] corresponds to track_offset[1].

Well, the problem is there anyways, since tracks[0] does have the track number 1.
The question rather is:

What is the least suprise?

for track_number in range(1, len(tracks)-1):
    print(track_offset[track_number])

or

for track_number in range(1, len(tracks)-1):
    print(track_offset[track_number-1])

Should the track_offsets be accessed by track_number or by "track_index"?

The decision in the libdiscid API and in this module currently was, that you should index by track_number and having track_*[0] to be something different a way to achieve this.

A related issue is #23 (Track objects?). That doesn't solve the index problem though.

[JonnyJD]

Well, a part of the question is:
Can the first track be something different than 1?

The standard says "The track numbering shall start with the value 01 and increment by one."
So the first track number is extracted from disc, but it should be 1 for every standard CD and musicbrainz DOES have problems when the first track wouldn't be 1. (I read a bit in the code).
This is one of the reasons why the first track is not discarded, even if it is a data track.

http://musicbrainz.org/release/046d66a3-ec8f-4d24-873f-21a11f67b0fb is the Quake game disc. First track is a data track (the game) the other 10 tracks are audio tracks.
The first track reported by the driver is still track number 1.

I'll yet have to see (even on the net) a single audio disc where the first track is not 1.

So that shouldn't be an issue.
I might however correct the code so it would technically fill the tracks before the first track. Just in case.

[JonnyJD]

One thing is a bit weird with my implementation:

for track in tracks:

directly doesn't work, since you don't want to list track 0 normally.

You are suppose to do:

for i in range(1, disc.last_track_num + 1):