Conversation
DiscId is still there (inherits from Disc), but a deprecation warning is printed on stderr.
This should merge some module-level read fixes Conflicts: discid.py
ghost
assigned
This splits the discid module into multiple modules: libdiscid.py loads libdiscid and extracts the constants disc.py is the Disc class and related functions (read/put) util.py has utility functsions (_encode/_decode)
This way sphinx can access them. Either way sphinx thinks they are defined in the discid package, and tries to extract the "docstring" from there. Actually the "docstring" is just sphinx reading the source in that case. Another option would be to access them as disid.libdiscid.* in sphinx, but that wouldn't document them as being in the main package.
JonnyJD
added a commit
that referenced
this pull request
Apr 23, 2013
We only depend on libdiscid >= 0.2.2 so we display "libdicid < 0.4.0" otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discid.py is now 600 lines long, we have a Disc/DiscId class that is quite big and are adding a Track class.
It might be wise to split these up in multiple files.