Skip to content

Conversation

@siv2r
Copy link
Contributor

@siv2r siv2r commented Mar 22, 2021

Description

Addresses #97

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines (Clean Code) of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested my code with OPTION_BUILD_SANITIZER and OPTION_TEST_MEMORYCHECK.
  • I have tested with Helgrind in case my code works with threading.

If you are unclear about any of the above checks, have a look at our documentation here

@viferga
Copy link
Member

viferga commented Mar 25, 2021

Can you add the future? #97 (comment)

@siv2r
Copy link
Contributor Author

siv2r commented Mar 25, 2021

I added the definition for Future. Sorry for the delay :)

@viferga viferga merged commit e2a0a39 into metacall:develop Mar 27, 2021
@siv2r siv2r deleted the update-types-doc branch March 29, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants