Added support for i8 and char types in rs_loader#661
Draft
SATVIKsynopsis wants to merge 8 commits intometacall:developfrom
Draft
Added support for i8 and char types in rs_loader#661SATVIKsynopsis wants to merge 8 commits intometacall:developfrom
SATVIKsynopsis wants to merge 8 commits intometacall:developfrom
Conversation
Member
|
it does not include i8 and also has this comment in the top: // these types are not compatible can you investigate why? |
Contributor
Author
|
Added the support for map type and added tests for it. |
Contributor
Author
|
Added add_map_string_string, add_map_string_int, and add_map_int_string functions in basic.rs with corresponding tests in metacall_rust_test.cpp. |
viferga
requested changes
Mar 12, 2026
| fn metacall_value_to_map(v: *mut c_void) -> *mut *mut c_void; | ||
| // fn metacall_value_to_ptr(v: *mut c_void) -> *mut c_void; | ||
| fn metacall_value_to_ptr(v: *mut c_void) -> *mut c_void; | ||
| fn metacall_value_create_ptr(ptr: *const c_void) -> *mut c_void; |
Member
There was a problem hiding this comment.
group this with all the create apis
| // Array = 9, | ||
| // Map = 10, | ||
| Map = 10, | ||
| // Pointer = 11, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
i8andchartypes in Rust loader.Fixes NA
Type of change
Checklist:
make testorctest -VV -R <test-name>)../docker-compose.sh test &> outputand attached the output.OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK.OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output.Helgrindin case my code works with threading.make clang-formatin order to format my code and my code follows the style guidelines.If you are unclear about any of the above checks, have a look at our documentation here.