Only generate an id if the identifying property is empty

lucas-koehler · lucas-koehler · commit 2bdd46fab303 · 2017-09-05T12:21:15.000+02:00
diff --git a/src/core/schema.service.impl.ts b/src/core/schema.service.impl.ts
@@ -29,7 +29,7 @@ const addToArray =
   if (data[key] === undefined) {
     data[key] = [];
   }
-  if (!_.isEmpty(identifyingProperty)) {
+  if (!_.isEmpty(identifyingProperty) && _.isEmpty(valueToAdd[identifyingProperty])) {
     valueToAdd[identifyingProperty] = uuid.v4();
   }
   const childArray = data[key];

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ const addToArray =`
`29`	`29`	`if (data[key] === undefined) {`
`30`	`30`	`data[key] = [];`
`31`	`31`	`}`
`32`		`- if (!_.isEmpty(identifyingProperty)) {`
	`32`	`+ if (!_.isEmpty(identifyingProperty) && _.isEmpty(valueToAdd[identifyingProperty])) {`
`33`	`33`	`valueToAdd[identifyingProperty] = uuid.v4();`
`34`	`34`	`}`
`35`	`35`	`const childArray = data[key];`