Introduce config object and fix linter warnings

Author: edgarmueller

src/core.ts

@@ -19,6 +19,23 @@ export interface JsonFormService {
   dispose(): void;
 }
 
+export class JsonFormsConfig {
+
+  private _identifyingProp;
+
+  setIdentifyingProp(propName: string) {
+    this._identifyingProp = propName;
+  }
+
+  getIdentifyingProp() {
+    return this._identifyingProp;
+  }
+
+  shouldGenerateIdentifier() {
+    return this._identifyingProp !== undefined;
+  }
+}
+
 /**
  * Encapsulates instantiation logic of a JSONForms service.
  */
@@ -37,6 +54,7 @@ export interface JsonFormsServiceConstructable {
  * Global JSONForms object that holds services and registries.
  */
 export class JsonForms {
+  private static _config = new JsonFormsConfig();
   private static _schemaService;
   public static rendererService = new RendererService();
   public static jsonFormsServices: JsonFormsServiceConstructable[] = [];
@@ -54,6 +72,10 @@ export class JsonForms {
     return this._schemaService;
   }
 
+  public static get config(): JsonFormsConfig {
+    return this._config;
+  }
+
   /**
    * Uses the model mapping to filter all objects that are associated with the type
    * defined by the given schema id. If there is no applicable mapping,

src/core/schema.service.impl.ts

@@ -9,6 +9,7 @@ import {
   SchemaService
 } from './schema.service';
 import * as uuid from 'uuid';
+import { JsonForms } from '../core';
 
 interface ReferenceSchemaMap {
   [ref: string]: JsonSchema;
@@ -139,7 +140,6 @@ const getReference = (href: string, variable: string, variableWrapped: string) =
   };
 
 export class SchemaServiceImpl implements SchemaService {
-  private _identifyingProp;
   private selfContainedSchemas: {[id: string]: JsonSchema} = {};
   constructor(private rootSchema: JsonSchema) {
     if (_.isEmpty(rootSchema.id)) {
@@ -194,7 +194,7 @@ export class SchemaServiceImpl implements SchemaService {
             variable,
             variable,
             pathToContainment.substring(0, pathToContainment.length - 1),
-            this._identifyingProp,
+            JsonForms.config.getIdentifyingProp(),
             addReference(schema, variable, pathToContainment),
             getReference(href, variable, variableWrapped)
           )
@@ -210,25 +210,6 @@ export class SchemaServiceImpl implements SchemaService {
     return [];
   }
 
-  /**
-   * @inheritDoc
-   */
-  setIdentifyingProp(propName: string): SchemaService {
-    this._identifyingProp = propName;
-
-    return this;
-  }
-
-  /**
-   * Determines whether the identifigenerer value should be generated
-   * @returns {boolean} true, if the the identifying value should be generated
-   *
-   * @see setIdentifyingProp
-   */
-  shouldGenerateIdentifier() {
-    return this._identifyingProp !== undefined;
-  }
-
   private getContainment(key: string, name: string, schema: JsonSchema, rootSchema: JsonSchema,
                          isInContainment: boolean,
                          addFunction: (data: object) => (valueToAdd: object,
@@ -276,7 +257,7 @@ export class SchemaServiceImpl implements SchemaService {
         schema.items,
         rootSchema,
         true,
-        addToArray(key, this._identifyingProp),
+        addToArray(key, JsonForms.config.getIdentifyingProp()),
         deleteFromArray(key),
         getArray(key)
       );

src/core/schema.service.ts

@@ -245,12 +245,4 @@ export interface SchemaService {
    * @see ReferenceProperty
    */
   getReferenceProperties(schema: JsonSchema): ReferenceProperty[];
-
-  /**
-   * Set the name of the property that uniquely identifies any given schema element.
-   *
-   * @param propName the name of the identifying property
-   * @return the schema service itself for convenience reasons
-   */
-  setIdentifyingProp(propName: string): SchemaService;
 }