clone oldData when reducing core.data to avoid state mutation in updater

jeremy-vineti · edgarmueller · commit c9cac3e0de93 · 2019-05-03T10:50:44.000+02:00
diff --git a/packages/core/src/reducers/core.ts b/packages/core/src/reducers/core.ts
@@ -210,7 +210,7 @@ export const coreReducer = (
         };
       } else {
         const oldData: any = get(state.data, action.path);
-        let newData = action.updater(oldData);
+        let newData = action.updater(cloneDeep(oldData));
         if (newData === '') {
           newData = undefined;
         }

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ export const coreReducer = (`
`210`	`210`	`};`
`211`	`211`	`} else {`
`212`	`212`	`const oldData: any = get(state.data, action.path);`
`213`		`- let newData = action.updater(oldData);`
	`213`	`+ let newData = action.updater(cloneDeep(oldData));`
`214`	`214`	`if (newData === '') {`
`215`	`215`	`newData = undefined;`
`216`	`216`	`}`