Skip to content

refactor: no need to use buffer to extract output #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

refactor: no need to use buffer to extract output #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions backend/src/main/java/net/laprun/sustainability/power/sensors/cpu/PSExtractionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import com.zaxxer.nuprocess.NuProcessBuilder;

import io.quarkus.logging.Log;
import net.laprun.sustainability.power.nuprocess.OutputRecordingProcessHandler;
import net.laprun.sustainability.power.nuprocess.BaseProcessHandler;

public class PSExtractionStrategy implements ExtractionStrategy {
public static final ExtractionStrategy INSTANCE = new PSExtractionStrategy();
Expand All @@ -18,8 +18,7 @@ public Map<String, Double> cpuSharesFor(Set<String> pids) {
final var cpuShares = new HashMap<String, Double>(pids.size());
final var pidList = String.join(",", pids);
final var cmd = new String[] { "ps", "-p", pidList, "-o", "pid=,pcpu=" };
// final var cmd = new String[] {"top", "-pid", "" + pid, "-l", "4", "-stats", "cpu"};
final var psHandler = new OutputRecordingProcessHandler(256, cmd) {
final var psHandler = new BaseProcessHandler(cmd) {

@Override
public void onStdout(ByteBuffer buffer, boolean closed) {
Expand Down
Loading