feat: use external CPU measure if not provided by sensor #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires creating copies of the "original" measure, so maybe the cpu share shouldn't be part of the components?
Note that the accuracy of this should be evaluated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the accuracy of this feature is still being considered, in particular when it comes to figuring out the proper ratio between the "full" CPU potential (as determined by number of available cores, each representing a potential 100% of CPU use) and the actually used CPU. This is currently achieved using averaging CPU usage as reported by
ps, sampled 3 times per actual CPU power measure. The code makes it possible to change the strategy used for this so different alternatives could be explored and the methodology should be reviewed.