Move Elasticsearch server setup to config files #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oalders
commented
Apr 28, 2024
oalders
commented
- Make config easier to get for now
- Get elasticsearch servers from config
oalders
force-pushed
the
oalders/cloud-config
branch
3 times, most recently
from
5f127f2 to
933d084
Compare
oalders
force-pushed
the
oalders/cloud-config
branch
from
d84f414 to
ef0c4d0
Compare
oalders
force-pushed
the
oalders/cloud-config
branch
2 times, most recently
from
ed24698 to
56f0f42
Compare
oalders
force-pushed
the
oalders/cloud-config
branch
4 times, most recently
from
57f30c3 to
dc055b9
Compare
mickeyn
previously approved these changes
Sep 9, 2024
haarg
reviewed
Sep 9, 2024
lib/MetaCPAN/Script/Runner.pm
Outdated
| use Hash::Merge::Simple qw( merge ); | ||
| use File::Path (); | ||
| use MetaCPAN::Server::Config (); | ||
| use Module::Pluggable qw( plugins ); |
There was a problem hiding this comment.
Here and in several other places duplicate use statements have been added.
There was a problem hiding this comment.
perlimports is ignoring Module::Pluggable, so this is not being caught in merge conflict resolution.
oalders
force-pushed
the
oalders/cloud-config
branch
5 times, most recently
from
a3687c8 to
7cf08db
Compare
…as being used as the model
oalders
force-pushed
the
oalders/cloud-config
branch
2 times, most recently
from
a6c6dc8 to
64aeeaa
Compare
oalders
force-pushed
the
oalders/cloud-config
branch
4 times, most recently
from
3074951 to
6eeaa43
Compare
Fix es config in script/mapping test
oalders
force-pushed
the
oalders/cloud-config
branch
from
6eeaa43 to
3423628
Compare
mickeyn
approved these changes
Sep 17, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.