use inline expression script for preferring short module names #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/search-prefer-short-inline
branch
2 times, most recently
from
568a5c1 to
66e8a39
Compare
The 'expression' language is faster, more secure, and supported on modern versions of Elasticsearch. It requires numeric fields. Now that we have the numeric `documentation_length` field, we can use it to prefer shorter names rather than needing to put files onto the ES servers.
haarg
force-pushed
the
haarg/search-prefer-short-inline
branch
from
66e8a39 to
d1571ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
- Coverage 60.05% 59.99% -0.07%
==========================================
Files 168 168
Lines 4509 4509
Branches 646 646
==========================================
- Hits 2708 2705 -3
- Misses 1571 1573 +2
- Partials 230 231 +1 ☔ View full report in Codecov by Sentry. |
oalders
approved these changes
May 6, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'expression' language is faster, more secure, and supported on modern versions of Elasticsearch. It requires numeric fields. Now that we have the numeric
documentation_lengthfield, we can use it to prefer shorter names rather than needing to put files onto the ES servers.