Skip to content

Conversation

@rwstauner
Copy link
Contributor

Is this the correct filter?

Currently the reverse_deps query returns multiple versions of any given release.
I think we only want the most recent version.

Are there are other filters that should be added here?
I wasn't able to write a test for authorized... should that be here, too?

@monken
Copy link
Contributor

monken commented Jan 11, 2012

You can get the same result already by sending a request body with {"filter":{"status":"latest"}} to that endpoint. Do we really want to limit that endpoint to latest releases?

@rwstauner
Copy link
Contributor Author

You're probably right.
It's easy to add the "latest" filter if that's what you want,
but probably difficult to remove it if that isn't what you want.

I guess it seemed odd to get duplicates or even old ones that no longer apply,
but that's really just a particular use-case.
You can get the same sort of results doing a "normal" release search,
so a user should be used to specifying "latest" when that is in fact what they want.

I may modify the tests to confirm the behavior.

@rwstauner
Copy link
Contributor Author

I rebased this branch and it is now just additional tests.

monken added a commit that referenced this pull request Jan 21, 2012
@monken monken merged commit 59125ff into master Jan 21, 2012
@ranguard ranguard deleted the rwstauner/rdeps-latest-versions branch April 15, 2016 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants