set pager size #1356

[szabgab]

No description provided.

[oalders]

@rwstauner or @haarg Would one of you like to review the JS in this pull request?

[oalders]

I think we could pare this down a bit by moving most of this logic into lib/MetaCPAN/Web/Role/Request.pm

Something like:

sub get_page_size {
    my $req = shift;
    my $default_page_size = shift;

    my $page_size = $req->param('size');
    unless ( is_PositiveInt($page_size) && $page_size <= 500 ) {
        $page_size = $default_page_size;
    }
    return $page_size;
}

The controllers should consume this role by default, so this would cut down on some boilerplate. If you're short on time, I can make these changes for you. Just let me know. I also see that you have different default page sizes, so we could deal with this here by suppl

[oalders]

I apologize that it has taken me so long to review the code. Thanks very much for taking this on. :)

[szabgab]

Rebased in pull request #1417

[oalders]

Thanks for the refactor. BTW, if you just force-push your branch that's enough to update the current pull request. There's no need to open a new pull request, unless you have other reasons for wanting to go that route.

[szabgab]

OK, I did not know that. Next time I'll try that.