Skip to content

Refactoring to clean up tech debt #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 26, 2025
Merged

Refactoring to clean up tech debt #54

merged 22 commits into from
Oct 26, 2025

Conversation

@tzanko-matev
Copy link
Contributor

@tzanko-matev tzanko-matev commented Oct 17, 2025

No description provided.

@tzanko-matev tzanko-matev changed the base branch from main to trace-filters October 17, 2025 16:04
@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Coverage Summary

Rust (lines)
80.9% covered (7,148 / 8,834 | 1,686 missed)

File Lines Miss Cover
codetracer-python-recorder/src/code_object.rs 117 16 86.3%
codetracer-python-recorder/src/ffi.rs 191 19 90.1%
codetracer-python-recorder/src/logging/logger.rs 273 66 75.8%
codetracer-python-recorder/src/monitoring/api.rs 162 149 8.0%
codetracer-python-recorder/src/monitoring/callbacks.rs 585 66 88.7%
codetracer-python-recorder/src/runtime/frame_inspector.rs 148 63 57.4%
codetracer-python-recorder/src/runtime/io_capture/fd_mirror/unix.rs 376 79 79.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/common.rs 159 62 61.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/input.rs 128 91 28.9%
codetracer-python-recorder/src/runtime/io_capture/proxies/output.rs 41 27 34.1%
codetracer-python-recorder/src/runtime/io_capture/sink/batcher.rs 238 21 91.2%
codetracer-python-recorder/src/runtime/io_capture/sink/enricher.rs 73 17 76.7%
codetracer-python-recorder/src/runtime/mod.rs 2,238 280 87.5%
codetracer-python-recorder/src/runtime/output_paths.rs 98 16 83.7%
codetracer-python-recorder/src/runtime/value_capture.rs 240 112 53.3%
codetracer-python-recorder/src/session.rs 84 84 0.0%
codetracer-python-recorder/src/session/bootstrap/filesystem.rs 90 32 64.4%
codetracer-python-recorder/src/trace_filter/engine.rs 529 68 87.1%
codetracer-python-recorder/src/trace_filter/loader.rs 435 196 54.9%
codetracer-python-recorder/src/trace_filter/selector.rs 258 66 74.4%
Showing top 20 entries by missed lines (of 48 total).

Python (statements)
76.3% covered (232 / 304 | 72 missed)

File Stmts Miss Cover
codetracer-python-recorder/codetracer_python_recorder/__init__.py 7 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/__main__.py 2 2 0.0%
codetracer-python-recorder/codetracer_python_recorder/api.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/auto_start.py 24 2 91.7%
codetracer-python-recorder/codetracer_python_recorder/cli.py 142 62 56.3%
codetracer-python-recorder/codetracer_python_recorder/formats.py 13 1 92.3%
codetracer-python-recorder/codetracer_python_recorder/session.py 111 5 95.5%

Generated automatically via generate_coverage_comment.py.

@tzanko-matev tzanko-matev force-pushed the trace-filters branch 2 times, most recently from 8cb53c6 to 5c4fef6 Compare October 24, 2025 13:28
Base automatically changed from trace-filters to main October 24, 2025 13:30
@tzanko-matev tzanko-matev force-pushed the refactor branch 2 times, most recently from c62d6b0 to e20cc24 Compare October 24, 2025 13:40
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Coverage Summary

Rust (lines)
81.2% covered (7,334 / 9,032 | 1,698 missed)

File Lines Miss Cover
codetracer-python-recorder/src/logging/logger.rs 273 64 76.6%
codetracer-python-recorder/src/monitoring/api.rs 162 149 8.0%
codetracer-python-recorder/src/monitoring/callbacks.rs 589 68 88.5%
codetracer-python-recorder/src/runtime/frame_inspector.rs 148 63 57.4%
codetracer-python-recorder/src/runtime/io_capture/fd_mirror/unix.rs 376 79 79.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/common.rs 159 62 61.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/input.rs 128 91 28.9%
codetracer-python-recorder/src/runtime/io_capture/proxies/output.rs 41 27 34.1%
codetracer-python-recorder/src/runtime/io_capture/sink/batcher.rs 238 21 91.2%
codetracer-python-recorder/src/runtime/tracer/events.rs 296 132 55.4%
codetracer-python-recorder/src/runtime/tracer/filtering.rs 128 32 75.0%
codetracer-python-recorder/src/runtime/tracer/io.rs 162 31 80.9%
codetracer-python-recorder/src/runtime/tracer/lifecycle.rs 231 46 80.1%
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs 1,615 51 96.8%
codetracer-python-recorder/src/runtime/value_capture.rs 240 112 53.3%
codetracer-python-recorder/src/session.rs 84 84 0.0%
codetracer-python-recorder/src/session/bootstrap/filesystem.rs 90 32 64.4%
codetracer-python-recorder/src/trace_filter/engine.rs 529 68 87.1%
codetracer-python-recorder/src/trace_filter/loader.rs 435 196 54.9%
codetracer-python-recorder/src/trace_filter/selector.rs 258 66 74.4%
Showing top 20 entries by missed lines (of 52 total).

Python (statements)
76.3% covered (232 / 304 | 72 missed)

File Stmts Miss Cover
codetracer-python-recorder/codetracer_python_recorder/__init__.py 7 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/__main__.py 2 2 0.0%
codetracer-python-recorder/codetracer_python_recorder/api.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/auto_start.py 24 2 91.7%
codetracer-python-recorder/codetracer_python_recorder/cli.py 142 62 56.3%
codetracer-python-recorder/codetracer_python_recorder/formats.py 13 1 92.3%
codetracer-python-recorder/codetracer_python_recorder/session.py 111 5 95.5%

Generated automatically via generate_coverage_comment.py.

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Coverage Summary

Rust (lines)
81.2% covered (7,334 / 9,032 | 1,698 missed)

File Lines Miss Cover
codetracer-python-recorder/src/logging/logger.rs 273 64 76.6%
codetracer-python-recorder/src/monitoring/api.rs 162 149 8.0%
codetracer-python-recorder/src/monitoring/callbacks.rs 589 68 88.5%
codetracer-python-recorder/src/runtime/frame_inspector.rs 148 63 57.4%
codetracer-python-recorder/src/runtime/io_capture/fd_mirror/unix.rs 376 79 79.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/common.rs 159 62 61.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/input.rs 128 91 28.9%
codetracer-python-recorder/src/runtime/io_capture/proxies/output.rs 41 27 34.1%
codetracer-python-recorder/src/runtime/io_capture/sink/batcher.rs 238 21 91.2%
codetracer-python-recorder/src/runtime/tracer/events.rs 296 132 55.4%
codetracer-python-recorder/src/runtime/tracer/filtering.rs 128 32 75.0%
codetracer-python-recorder/src/runtime/tracer/io.rs 162 31 80.9%
codetracer-python-recorder/src/runtime/tracer/lifecycle.rs 231 46 80.1%
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs 1,615 51 96.8%
codetracer-python-recorder/src/runtime/value_capture.rs 240 112 53.3%
codetracer-python-recorder/src/session.rs 84 84 0.0%
codetracer-python-recorder/src/session/bootstrap/filesystem.rs 90 32 64.4%
codetracer-python-recorder/src/trace_filter/engine.rs 529 68 87.1%
codetracer-python-recorder/src/trace_filter/loader.rs 435 196 54.9%
codetracer-python-recorder/src/trace_filter/selector.rs 258 66 74.4%
Showing top 20 entries by missed lines (of 52 total).

Python (statements)
76.3% covered (232 / 304 | 72 missed)

File Stmts Miss Cover
codetracer-python-recorder/codetracer_python_recorder/__init__.py 7 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/__main__.py 2 2 0.0%
codetracer-python-recorder/codetracer_python_recorder/api.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/auto_start.py 24 2 91.7%
codetracer-python-recorder/codetracer_python_recorder/cli.py 142 62 56.3%
codetracer-python-recorder/codetracer_python_recorder/formats.py 13 1 92.3%
codetracer-python-recorder/codetracer_python_recorder/session.py 111 5 95.5%

Generated automatically via generate_coverage_comment.py.

@tzanko-matev
Refactoring
0ed8b81 
design-docs/adr/0011-codetracer-architecture-refactor.md: 
design-docs/codetracer-architecture-refactor-implementation-plan.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 1 - Step 1
ac0c69f 
codetracer-python-recorder/src/trace_filter/config.rs: 
codetracer-python-recorder/src/trace_filter/loader.rs: 
codetracer-python-recorder/src/trace_filter/mod.rs: 
codetracer-python-recorder/src/trace_filter/model.rs: 
codetracer-python-recorder/src/trace_filter/summary.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 1 - Step 2
59f84b3 
codetracer-python-recorder/src/trace_filter/config.rs: 
codetracer-python-recorder/src/trace_filter/loader.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 1 - Step 3
dcbed13 
codetracer-python-recorder/src/trace_filter/model.rs: 
codetracer-python-recorder/src/trace_filter/summary.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 2 - Step 1
f861904 
codetracer-python-recorder/src/logging/logger.rs: 

codetracer-python-recorder/src/logging/metrics.rs: 
codetracer-python-recorder/src/logging/trailer.rs: 
codetracer-python-recorder/src/policy/env.rs: 
codetracer-python-recorder/src/policy/ffi.rs: 
codetracer-python-recorder/src/policy/model.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 2 - Step 2
603b597
@tzanko-matev
Milestone 2 - Step 3
bcdf089 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 2 - Step 4
5a1487b
@tzanko-matev
Milestone 3 - Step 1
feb8c05 
codetracer-python-recorder/src/logging.rs: 
codetracer-python-recorder/src/session/bootstrap/filesystem.rs: 
codetracer-python-recorder/src/session/bootstrap/filters.rs: 
codetracer-python-recorder/src/session/bootstrap/metadata.rs: 
codetracer-python-recorder/src/session/bootstrap.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 3 - Step 2
fc2f6a4 
codetracer-python-recorder/src/session/bootstrap/filesystem.rs: 
codetracer-python-recorder/src/session/bootstrap/filters.rs: 
codetracer-python-recorder/src/session/bootstrap/metadata.rs: 
codetracer-python-recorder/src/session/bootstrap.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 4 - Step 1
3f4ce8b 
codetracer-python-recorder/src/monitoring/api.rs: 
codetracer-python-recorder/src/monitoring/callbacks.rs: 
codetracer-python-recorder/src/monitoring/install.rs: 
codetracer-python-recorder/src/monitoring/mod.rs: 
codetracer-python-recorder/src/monitoring/tracer.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 4 - step 2
711c122
@tzanko-matev
Milestone 5 - Step 0
3f0e50f 
codetracer-python-recorder/src/runtime/mod.rs: 
codetracer-python-recorder/src/runtime/tracer/events.rs: 
codetracer-python-recorder/src/runtime/tracer/filtering.rs: 
codetracer-python-recorder/src/runtime/tracer/io.rs: 
codetracer-python-recorder/src/runtime/tracer/lifecycle.rs: 
codetracer-python-recorder/src/runtime/tracer/mod.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 5 - Step 1
d8086c7 
codetracer-python-recorder/src/runtime/mod.rs: 
codetracer-python-recorder/src/runtime/tracer/mod.rs: 
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 5 - Step 2
9a3db00 
codetracer-python-recorder/src/runtime/tracer/io.rs: 
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 5 - Step 3
0ce9bf5 
codetracer-python-recorder/src/runtime/tracer/filtering.rs: 
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 5 - Step 4
a8f6d23 
codetracer-python-recorder/src/logging.rs: 
codetracer-python-recorder/src/runtime/tracer/lifecycle.rs: 
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 5 - Step 5
abc598f 
codetracer-python-recorder/src/runtime/tracer/events.rs: 
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 5 - Step 6
8be3675 
codetracer-python-recorder/src/runtime/mod.rs: 
codetracer-python-recorder/src/runtime/tracer/io.rs: 
codetracer-python-recorder/src/runtime/tracer/mod.rs: 
design-docs/adr/0001-file-level-single-responsibility.md: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 
design-docs/file-level-srp-refactor-plan.md: 
design-docs/value-capture.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Milestone 6 - Step 0
c56c9a2 
codetracer-python-recorder/src/monitoring/callbacks.rs: 
codetracer-python-recorder/src/monitoring/mod.rs: 
codetracer-python-recorder/src/runtime/tracer/mod.rs: 
design-docs/codetracer-architecture-refactor-implementation-plan.status.md: 

Signed-off-by: Tzanko Matev <tsanko@metacraft-labs.com>
@tzanko-matev
Fix python benchmark test
04d9cb0
@tzanko-matev
Milestone 6 - wrap-up
1ff52ea
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Coverage Summary

Rust (lines)
81.2% covered (7,334 / 9,032 | 1,698 missed)

File Lines Miss Cover
codetracer-python-recorder/src/logging/logger.rs 273 64 76.6%
codetracer-python-recorder/src/monitoring/api.rs 162 149 8.0%
codetracer-python-recorder/src/monitoring/callbacks.rs 589 68 88.5%
codetracer-python-recorder/src/runtime/frame_inspector.rs 148 63 57.4%
codetracer-python-recorder/src/runtime/io_capture/fd_mirror/unix.rs 376 79 79.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/common.rs 159 62 61.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/input.rs 128 91 28.9%
codetracer-python-recorder/src/runtime/io_capture/proxies/output.rs 41 27 34.1%
codetracer-python-recorder/src/runtime/io_capture/sink/batcher.rs 238 21 91.2%
codetracer-python-recorder/src/runtime/tracer/events.rs 296 132 55.4%
codetracer-python-recorder/src/runtime/tracer/filtering.rs 128 32 75.0%
codetracer-python-recorder/src/runtime/tracer/io.rs 162 31 80.9%
codetracer-python-recorder/src/runtime/tracer/lifecycle.rs 231 46 80.1%
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs 1,615 51 96.8%
codetracer-python-recorder/src/runtime/value_capture.rs 240 112 53.3%
codetracer-python-recorder/src/session.rs 84 84 0.0%
codetracer-python-recorder/src/session/bootstrap/filesystem.rs 90 32 64.4%
codetracer-python-recorder/src/trace_filter/engine.rs 529 68 87.1%
codetracer-python-recorder/src/trace_filter/loader.rs 435 196 54.9%
codetracer-python-recorder/src/trace_filter/selector.rs 258 66 74.4%
Showing top 20 entries by missed lines (of 52 total).

Python (statements)
76.3% covered (232 / 304 | 72 missed)

File Stmts Miss Cover
codetracer-python-recorder/codetracer_python_recorder/__init__.py 7 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/__main__.py 2 2 0.0%
codetracer-python-recorder/codetracer_python_recorder/api.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/auto_start.py 24 2 91.7%
codetracer-python-recorder/codetracer_python_recorder/cli.py 142 62 56.3%
codetracer-python-recorder/codetracer_python_recorder/formats.py 13 1 92.3%
codetracer-python-recorder/codetracer_python_recorder/session.py 111 5 95.5%

Generated automatically via generate_coverage_comment.py.

@tzanko-matev tzanko-matev marked this pull request as ready for review October 26, 2025 11:14
@github-actions
Copy link

github-actions bot commented Oct 26, 2025

Coverage Summary

Rust (lines)
81.2% covered (7,336 / 9,032 | 1,696 missed)

File Lines Miss Cover
codetracer-python-recorder/src/logging/logger.rs 273 64 76.6%
codetracer-python-recorder/src/monitoring/api.rs 162 149 8.0%
codetracer-python-recorder/src/monitoring/callbacks.rs 589 68 88.5%
codetracer-python-recorder/src/runtime/frame_inspector.rs 148 63 57.4%
codetracer-python-recorder/src/runtime/io_capture/fd_mirror/unix.rs 376 79 79.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/common.rs 159 62 61.0%
codetracer-python-recorder/src/runtime/io_capture/proxies/input.rs 128 91 28.9%
codetracer-python-recorder/src/runtime/io_capture/proxies/output.rs 41 27 34.1%
codetracer-python-recorder/src/runtime/io_capture/sink/batcher.rs 238 21 91.2%
codetracer-python-recorder/src/runtime/tracer/events.rs 296 132 55.4%
codetracer-python-recorder/src/runtime/tracer/filtering.rs 128 32 75.0%
codetracer-python-recorder/src/runtime/tracer/io.rs 162 29 82.1%
codetracer-python-recorder/src/runtime/tracer/lifecycle.rs 231 46 80.1%
codetracer-python-recorder/src/runtime/tracer/runtime_tracer.rs 1,615 51 96.8%
codetracer-python-recorder/src/runtime/value_capture.rs 240 112 53.3%
codetracer-python-recorder/src/session.rs 84 84 0.0%
codetracer-python-recorder/src/session/bootstrap/filesystem.rs 90 32 64.4%
codetracer-python-recorder/src/trace_filter/engine.rs 529 68 87.1%
codetracer-python-recorder/src/trace_filter/loader.rs 435 196 54.9%
codetracer-python-recorder/src/trace_filter/selector.rs 258 66 74.4%
Showing top 20 entries by missed lines (of 52 total).

Python (statements)
76.3% covered (232 / 304 | 72 missed)

File Stmts Miss Cover
codetracer-python-recorder/codetracer_python_recorder/__init__.py 7 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/__main__.py 2 2 0.0%
codetracer-python-recorder/codetracer_python_recorder/api.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/auto_start.py 24 2 91.7%
codetracer-python-recorder/codetracer_python_recorder/cli.py 142 62 56.3%
codetracer-python-recorder/codetracer_python_recorder/formats.py 13 1 92.3%
codetracer-python-recorder/codetracer_python_recorder/session.py 111 5 95.5%

Generated automatically via generate_coverage_comment.py.

@tzanko-matev tzanko-matev merged commit 97b900e into main Oct 26, 2025
6 checks passed
@tzanko-matev tzanko-matev deleted the refactor branch October 26, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tzanko-matev