Introduce new binary and unary op for sparse_tensor #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`binary` performs a sparse binary operation within linalg.generic, providing the flexibility to do intersection or union or even more advanced (ex. A-B -> -B when A is missing) `unary` performs a sparse unary operation within linalg.generic Both the "present" and "missing" values can return a result, allowing for a simple apply, converting sparse to dense (e.g. A+1), or even performing a sparse mask inversion
paul-tqh-nguyen
approved these changes
Mar 4, 2022
| let summary = "Yield from sparse_tensor set operations"; | ||
| let description = [{ | ||
| Yield a value from within a block. | ||
| Used to terminate a block in sparse_tensor set-like operations. |
There was a problem hiding this comment.
The description would benefit from what "set-like" explicitly means.
| #include "mlir/IR/Matchers.h" | ||
| #include "mlir/IR/OpImplementation.h" | ||
| #include "llvm/ADT/TypeSwitch.h" | ||
| #include <iostream> |
There was a problem hiding this comment.
Is this used? Maybe I missed it, but I'm unsure if this include is necessary.
Author
There was a problem hiding this comment.
Good catch! That was a leftover from debugging.
Remove unused include Improve explanatory text about set-like operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binaryperforms a sparse binary operation within linalg.generic,providing the flexibility to do intersection or union or even more
advanced (ex. A-B -> -B when A is missing)
unaryperforms a sparse unary operation within linalg.genericBoth the "present" and "missing" values can return a result, allowing
for a simple apply, converting sparse to dense (e.g. A+1), or even
performing a sparse mask inversion