Partition Capacity #100
Merged
Partition Capacity #100
+3,181
−347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
force-pushed
the
partition-capacity
branch
from
501e436 to
db1b32c
Compare
majst01
commented
Feb 11, 2026
| // Partition of which this capacity is reported. | ||
| string partition = 1; | ||
| // ServerCapacities is the capacity per machine size. | ||
| repeated ServerCapacity server_capacities = 2; |
Contributor
Author
There was a problem hiding this comment.
ServerCapacity is a weird name, just carried this over from metal-api (i actually introduced this name 6 years ago) but i would rather prefer something like MachineSizeCapacity
majst01
force-pushed
the
partition-capacity
branch
from
db1b32c to
172d0dc
Compare
Gerrit91
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Partition Capacity Message, also fix token persister test.