This repository was archived by the owner on Jul 21, 2025. It is now read-only.
fix: make getEdition a static method#53
Merged
zaxozhu merged 1 commit intometaplex-foundation:mainfrom Nov 9, 2021
Merged
Conversation
kurpav
approved these changes
Nov 6, 2021
b2kdaman
approved these changes
Nov 8, 2021
Contributor
|
Makes sense to me. Needs a semver major version bump |
Contributor
|
@aheckmann yes, it's a breaking change. |
Contributor
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aheckmann
reviewed
Nov 9, 2021
Contributor
aheckmann
left a comment
aheckmann
left a comment
There was a problem hiding this comment.
Will merging this as is result in an auto-release as semver patch?
Contributor
|
Ha! I guess not. Cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getEditionseem like a really useful addition to the metadata class - but when it's not static it's kinda hard to use.Not sure if there was a reason for it being like this, but I couldn't find any in the codebase. Also making it static seems in line with other methods on
Metadata.Lmk if I missed something ¯_(ツ)_/¯