Skip to content

Conversation

@david-waltermire
Copy link
Contributor

Committer Notes

Addressed a bug caused when an immutable collection is returned and items are attempted to be removed from them. Adjusted the method of getting the collection to ensure a mutable collection is returned allowing items to be removed.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

…tems are attempted to be removed from them. Adjusted the method of getting the collection to ensure a mutable collection is returned allowing items to be removed.
@wandmagic
Copy link

looks good this should fix the latest release of the tool on profile resolution

Copy link

@wandmagic wandmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for making this fix

@david-waltermire david-waltermire merged commit 884d6d4 into metaschema-framework:release/4.0 Aug 8, 2024
@david-waltermire david-waltermire deleted the fixed-immutable-remove branch August 8, 2024 15:42
david-waltermire pushed a commit that referenced this pull request Aug 8, 2024
…tems are attempted to be removed from them. Adjusted the method of getting the collection to ensure a mutable collection is returned allowing items to be removed. (#20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants