Skip to content

Conversation

@david-waltermire
Copy link
Contributor

Committer Notes

  • Bumped library version from 4.1.1 to 4.2.0.
  • Implemented the BOM-based dependency management for junit5 and log4j2.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

@david-waltermire david-waltermire changed the title Bumped library version from 4.1.1 to 4.2.0. Implemented the BOM-based… Bump to v4.2.0 Oct 3, 2024
@david-waltermire david-waltermire marked this pull request as draft October 3, 2024 17:21
@aj-stein-gsa
Copy link
Contributor

So I've been curious how you get this to work in GHA or your local env, because I actually had some problems making it work in my local developer environment when I first tried. I got the same error in GHA when I first set up Eclipse that currently fails the build

Error:  	Could not find artifact dev.metaschema.java:metaschema-maven-plugin:jar:1.2.0-SNAPSHOT
Error:  -> [Help 1]

To work around this, I had to open a shell outside of Eclipse and do a mvn clean install first so the plugin exists and does not break the first Eclipse-based build. Is there something I am missing? I wondered if this relates to our inability to host snapshots outside of local file-based Maven cache, but maybe I am wrong. Sorry for not asking this naive question sooner.

@david-waltermire david-waltermire force-pushed the feature/v4.2.0 branch 2 times, most recently from 3e85cdf to 428e546 Compare October 7, 2024 00:21
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still draft, but I don't want it to be, let's go to prod!

@david-waltermire
Copy link
Contributor Author

So I've been curious how you get this to work in GHA or your local env, because I actually had some problems making it work in my local developer environment when I first tried. I got the same error in GHA when I first set up Eclipse that currently fails the build

Error:  	Could not find artifact dev.metaschema.java:metaschema-maven-plugin:jar:1.2.0-SNAPSHOT
Error:  -> [Help 1]

To work around this, I had to open a shell outside of Eclipse and do a mvn clean install first so the plugin exists and does not break the first Eclipse-based build. Is there something I am missing? I wondered if this relates to our inability to host snapshots outside of local file-based Maven cache, but maybe I am wrong. Sorry for not asking this naive question sooner.

You need to build each snapshot dependency in sequence locally.

@david-waltermire david-waltermire marked this pull request as ready for review October 8, 2024 20:51
@david-waltermire david-waltermire merged commit 3b99306 into metaschema-framework:develop Oct 8, 2024
@david-waltermire david-waltermire deleted the feature/v4.2.0 branch October 8, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants