Check consistency in tests for deprecated outputs/inputs names#225
Merged
Merged
Conversation
GardevoirX
reviewed
May 13, 2026
Contributor
GardevoirX
left a comment
GardevoirX
left a comment
There was a problem hiding this comment.
LGTM, will merge after the CI is happy
This allows to also catch a bug related to mutating the output dict while iterating over it
Luthaf
force-pushed
the
check-consistency-deprecated
branch
from
0b7d0d3 to
37810be
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to also catch a bug related to mutating the output dict while iterating over it
Cleanup of #224, thanks @ppegolo for finding and reporting this!
Contributor (creator of pull-request) checklist
Documentation updated (for new features)?Reviewer checklist
CHANGELOG updated with public API or any other important changes?