Implement System in metatomic-core#246
Merged
Merged
Conversation
frostedoyster
force-pushed
the
metatomic-core-system
branch
from
f124022 to
92f371a
Compare
Member
|
Can you move serialization to a different PR? Also, the format should be the exact same as existing .mta, there is no need to add a new format. |
frostedoyster
force-pushed
the
metatomic-core-system
branch
from
5360628 to
1573c99
Compare
Contributor
Author
|
Done, this PR now only contains the implementation of System |
frostedoyster
force-pushed
the
metatomic-core-system
branch
from
b3026c4 to
aa0aef7
Compare
4 tasks
Luthaf
force-pushed
the
metatomic-core
branch
2 times, most recently
from
b024db0 to
4a4484a
Compare
Luthaf
force-pushed
the
metatomic-core-system
branch
from
aa0aef7 to
b5b93a1
Compare
Co-Authored-By: frostedoyster <bigi.f@libero.it>
Luthaf
force-pushed
the
metatomic-core-system
branch
from
b5b93a1 to
acc3d02
Compare
Luthaf
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
SystemCoreinmetatomic-core. Since the arrays are DLPack (meaning we have no indexing or operations), checks on the arrays are left to the wrapping classes. Checks on the keys of the two extra data and neighbor list maps are still performed [note that, for now, duplicate keys are rejected in both cases]. A separate publicSystemclass exposes systems to Rust usersEDIT:
Systemis now gone andSystemCoreis renamed toSystem, we're not going to offer a wrapper for usage in RustContributor (creator of pull-request) checklist
Issue referenced (for PRs that solve an issue)?Reviewer checklist
CHANGELOG updated with public API or any other important changes?📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request
📚 Download documentation for this pull-request