Add supporting std::filesystem::path#42
Add supporting std::filesystem::path#42metayeti merged 3 commits intometayeti:masterfrom adamgene:wip/adam/support_filesystem_path
Conversation
|
I am not sure which formater should use, It's fine to re-formating by you. |
|
@metayeti Could you check these changes? I want to discuss another approach. As you can see, |
|
Hey. This looks proper, thanks for the PR - I will most likely merge it. The only things missing I think is updating version numbers and the changelog - but I can do those. I'll review by the end of the week in more detail |
1. to force writing utf8bom into test file. Because Windows can not support unicode in char. 2. merge tests to verify read/write.
|
I tested on both Windows and macOS, and made changes to fix some errors. |
|
Merged, ty for the contribution! Also sorry you had to wait a bit. |
|
ftr this ups the requires C++ version to 17 from like 11 or 98... |
True, I didn't really think about that. Doesn't bother me personally but I can see how it may be an issue for some. |
|
You can use last mINI 0.9.17 that still uses std::string w/o c++17. Maybe add a warning in README.md?
|
|
I'll add a note to releases for now. I may retroactively add one in readme at a next update |
Support std::filesystem::path, also add testing and cmake. I tested in Ubuntu 24.04 with gcc 13, also 20.04 with gcc 9.4.0 and 8.X. I already use this simplest change from 0.9.10, and used in VS2017~2022/macOS.