preserve consumer-provided "runOnJobQueue" value when set to True#23
Merged
Conversation
Previously, the "runOnJobQueue" parameter was always overwritten with False, even if a consumer explicitly passed True. This behavior prevented consumers from skipping the initial attempt without the job queue, even when it was certain their query would go to the job queue. By using setdefault(), the parameter is only set to False if it is not already provided. This change allows consumers who know their query requires the job queue to bypass the first attempt and directly push the job to the queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the "runOnJobQueue" parameter was always overwritten with False, even if a consumer explicitly passed True. This behavior prevented consumers from skipping the initial attempt without the job queue, even when it was certain their query would go to the job queue.
By using setdefault(), the parameter is only set to False if it is not already provided. This change allows consumers who know their query requires the job queue to bypass the first attempt and directly push the job to the queue.