Skip to content

Conversation

@fpoirier1
Copy link
Contributor

There you go, I've create a configurable onSubmit hook. I'm not sure about the diff for the "default" key though.

@fpoirier1
Copy link
Contributor Author

We just need to set avoidRedirect = true in side the hook to prevent redirection.

lib/client.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you checking this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, this is an old comment. It shoudn't be there.

@splendido
Copy link
Member

I'm sorry I'm being fussy...
If you have tested it and you say it's working, I'm going to merge it!

@fpoirier1
Copy link
Contributor Author

No worries, it is your package lets make the way you see it. We can call the submitHook before the postSubmitRedirect call but wouldn't be better to call it onSuccessHook then?

splendido added a commit that referenced this pull request Dec 12, 2014
@splendido splendido merged commit fb7de51 into meteor-useraccounts:master Dec 12, 2014
@splendido
Copy link
Member

Yeah, it's fine!
the way you put it allows for more use cases I guess, including playing some warn sound in case the submit fails ;-)

@splendido
Copy link
Member

thanks a lot!
I'm going to try fix some bug and then publish a new release...

@splendido
Copy link
Member

...also, yes it is my package but I'd like it to be as much useful/configurable as possible, so it's fine you pull me your way :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants