Fixed regression errors#125
Merged
alpha-tango-kilo merged 13 commits intomfaerevaag:masterfrom May 23, 2024
p1r473:wip
Merged
Conversation
Collaborator
|
Looks like you've got a conflict. Once you've resolved that, happy to merge :) |
Contributor
Author
|
Fixed! |
alpha-tango-kilo
approved these changes
May 23, 2024
Collaborator
alpha-tango-kilo
left a comment
alpha-tango-kilo
left a comment
There was a problem hiding this comment.
Okay, now I'm just curious as to what you've changed that fixes your regression
You've renamed and removed the local keyword from a variable declaration. How did that fix the issue?
Contributor
Author
|
I also renamed the variable from fzf_command to selected_entry as I had renamed it during testing and was not actually utilizing that new variable name |
Contributor
Author
|
I didn't remove the local, the local is previously declared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When I had added the delete functionality I accidently broke the browse functionality. Oops!
This fixes it.