[upgrade] added functionality to handle Properties#51
Merged
mfarragher merged 3 commits intoJun 6, 2026
Merged
Conversation
- functionality to handle [Properties](https://help.obsidian.md/properties) - limitation: - links in properties are not being handled
Veethahavya
commented
Jul 17, 2025
Author
Veethahavya
left a comment
Veethahavya
left a comment
There was a problem hiding this comment.
also added:
- a notebook to illustrate functionality
|
@mfarragher would be great if this PR could go in (allowing support for frontmatter properties is even more important now with the release of Obsidian Bases) |
mfarragher
approved these changes
Jun 6, 2026
Owner
mfarragher
left a comment
mfarragher
left a comment
There was a problem hiding this comment.
I'm going to merge this into a branch called dev_with_properties to do further development.
Examples of tweaks I'll make:
.obsidian/types.jsoncontains types likedatetime. That could be used to make the parsing logic more robust and generalise better than it does currently.- I'll re-organise the files used for tests
- Some of the original tests that check the vault object are failing (they need to account for the new
rich.mdfile in this PR).
Comment on lines
+560
to
+594
| if isinstance(value, str): | ||
| if clean_key == 'date' and len(value) == 10 and value[4] == '-' and value[7] == '-': | ||
| try: | ||
| value = datetime.datetime.strptime(value, '%Y-%m-%d').date() | ||
| except ValueError: | ||
| print(f"Failed to parse date for key '{clean_key}' with value '{value}' in frontmatter of {filepath}") | ||
| elif clean_key == 'time' and len(value) == 19 and value[4] == '-' and value[7] == '-' and value[10] == 'T': | ||
| try: | ||
| value = datetime.datetime.strptime(value, '%Y-%m-%dT%H:%M:%S') | ||
| except ValueError: | ||
| pass | ||
| elif clean_key == 'due' and len(value) == 10 and value[4] == '-' and value[7] == '-': | ||
| try: | ||
| value = datetime.datetime.strptime(value, '%Y-%m-%d').date() | ||
| except ValueError: | ||
| pass | ||
| elif value.startswith("[[") and value.endswith("]]"): | ||
| # Handle single wikilink as a string | ||
| value = _get_all_wikilinks_from_source_text(value, remove_aliases=True)[0] | ||
| elif isinstance(value, list): | ||
| # Handle list of strings, checking for wikilinks | ||
| new_list = [] | ||
| for item in value: | ||
| if isinstance(item, str) and item.startswith("[[") and item.endswith("]]"): | ||
| # Extract the wikilink | ||
| new_list.extend(_get_all_wikilinks_from_source_text(item, remove_aliases=True)) | ||
| else: | ||
| new_list.append(item) | ||
| value = new_list | ||
| if clean_key in ('date', 'due') and all(isinstance(item, str) and len(item) == 10 and item[4] == '-' and item[7] == '-' for item in value): | ||
| try: # Convert to date objects if they match the pattern | ||
| value = datetime.datetime.strptime(value, '%Y-%m-%d').date() | ||
| except ValueError: | ||
| pass | ||
| props[clean_key] = value |
Owner
There was a problem hiding this comment.
This parsing looks like it could be simplified
Owner
|
@Veethahavya I've reworked the logic so that it is all integrated in However a few edge case tests aren't working now and I'm not sure why, but it might be quicker for you to debug?: issue #56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves:
Credits: