hammerspoon: mask modifiers before launching apps#5
Open
mfkd wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Code review findings:
Static checks passed (luac -p, git diff --check), but I could not validate the runtime event-state behavior in Hammerspoon/macOS. The safer zero-latency direction is to avoid using real macOS startup modifiers for launcher hotkeys and instead move the launcher layer off the modifier chord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
This supersedes #4. PR #4 avoids startup modifier leakage by waiting until the physical modifiers are released, but that adds perceived launch latency. This PR masks the modifiers immediately instead.
Test