Skip to content

refactor(writers): split the shared helper module into cohesive submodules#63

Merged
mfkrause merged 1 commit into
mainfrom
refactor/split-writers-common
Jul 4, 2026
Merged

refactor(writers): split the shared helper module into cohesive submodules#63
mfkrause merged 1 commit into
mainfrom
refactor/split-writers-common

Conversation

@mfkrause

@mfkrause mfkrause commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Summary

The 2,622-line writers' common.rs becomes a common/ tree of nine cohesive submodules re-exported through mod.rs — pure code motion with zero consumer churn and no output change. The redundant per-item feature gates are replaced by one policy per module: a module-level cfg where the consumers form a single feature family (table_layout), and a module-level allow(dead_code) for the cross-cutting toolboxes.

Related issues

None.

Checklist

  • I have read CONTRIBUTING.md and followed its rules.
  • All checks and tests pass locally.
  • I added or updated tests for the change, if needed.
  • If this changes support for a format or extension, I updated README.md and/or docs/STATUS.md.
  • My commits follow Conventional Commits — the changelog is generated from them, so no manual CHANGELOG.md edit is needed.

@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mfkrause, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 27b2754e-8d1d-4515-a7ea-d8717f624ac5

📥 Commits

Reviewing files that changed from the base of the PR and between e880bef and c30b56e.

📒 Files selected for processing (11)
  • crates/carta-writers/src/common.rs
  • crates/carta-writers/src/common/dimensions.rs
  • crates/carta-writers/src/common/fill.rs
  • crates/carta-writers/src/common/html_attr.rs
  • crates/carta-writers/src/common/lists.rs
  • crates/carta-writers/src/common/mod.rs
  • crates/carta-writers/src/common/notes.rs
  • crates/carta-writers/src/common/table_layout.rs
  • crates/carta-writers/src/common/tables.rs
  • crates/carta-writers/src/common/uri.rs
  • crates/carta-writers/src/common/width.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/split-writers-common

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mfkrause mfkrause merged commit e205af6 into main Jul 4, 2026
25 checks passed
@mfkrause mfkrause deleted the refactor/split-writers-common branch July 4, 2026 19:31
@carta-release carta-release Bot mentioned this pull request Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant