Skip to content

Conversation

@mfl28
Copy link
Owner

@mfl28 mfl28 commented Oct 29, 2022

  • Before loading, EXIF data in jpeg images is parsed and (if present) the orientation tag is extracted.
  • Jpeg images with EXIF orientation data are now loaded (in main view and file explorer side-panel) with correct orientation based on the extracted orientation tag.
  • Annotation import/export and bounding box prediction handling are updated to correctly handle images with EXIF orientation data.
  • Maximum image loading size in main image view is changed to 3072 x 3072 (from non-square 3200 x 2000).
  • Adds test jpegs with EXIF orientation and unit tests to test image loading, annotation and bounding-box prediction handling for images with EXIF orientation.

Closes #42 .

@mfl28 mfl28 self-assigned this Oct 29, 2022
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 85.61% // Head: 85.99% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (8a7e3a8) compared to base (ba7f6d6).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #43      +/-   ##
============================================
+ Coverage     85.61%   85.99%   +0.37%     
- Complexity     1368     1405      +37     
============================================
  Files            91       92       +1     
  Lines          5639     5739     +100     
  Branches        511      518       +7     
============================================
+ Hits           4828     4935     +107     
+ Misses          548      546       -2     
+ Partials        263      258       -5     
Impacted Files Coverage Δ
...om/github/mfl28/boundingboxeditor/model/Model.java 87.94% <47.82%> (+0.08%) ⬆️
...8/boundingboxeditor/ui/WorkspaceSplitPaneView.java 82.20% <80.00%> (+0.12%) ⬆️
...mfl28/boundingboxeditor/controller/Controller.java 78.22% <84.21%> (+0.29%) ⬆️
...28/boundingboxeditor/model/data/ImageMetaData.java 86.76% <85.71%> (-2.13%) ⬇️
...8/boundingboxeditor/model/io/PVOCSaveStrategy.java 88.59% <90.00%> (ø)
.../mfl28/boundingboxeditor/ui/ImageFileListView.java 88.17% <90.00%> (+1.50%) ⬆️
.../boundingboxeditor/model/data/ImageAnnotation.java 100.00% <100.00%> (ø)
...undingboxeditor/model/io/BoundingBoxPredictor.java 86.66% <100.00%> (+8.09%) ⬆️
...8/boundingboxeditor/model/io/JSONSaveStrategy.java 94.00% <100.00%> (+1.50%) ⬆️
...8/boundingboxeditor/model/io/PVOCLoadStrategy.java 76.57% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.5% 93.5% Coverage
0.0% 0.0% Duplication

@mfl28 mfl28 merged commit 60c70d8 into master Oct 30, 2022
@mfl28 mfl28 deleted the feature/correctly-handle-exif-oriented-jpeg-images branch October 30, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correctly handle jpeg images with EXIF orientation data

2 participants