chore: package.json から engines フィールドを削除(OSS 公開方針復元)#190
Merged
Conversation
CONTRIBUTING.md L36「Node.js LTS 以降を推奨」の記述通り、 starter は OSS 公開リポとして広いユーザー層対応のため engines を意図的に未指定とする方針。 e19a7a8 で engines: { node: ">=24.0.0" } を追加したが、 これは wp-starter(案件用・開発環境固定の意図的判断)との整合を誤って starter に適用した誤判断。engines フィールドのみ削除して方針を復元する。 vite ^8.0.5 は維持(e19a7a8 のバージョン追従は有効)。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying starter with
|
| Latest commit: |
13c5134
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8ccf90a.starter-20t.pages.dev |
| Branch Preview URL: | https://fix-v1-2-remove-engines-fiel.starter-20t.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
e19a7a8 で誤って追加された
enginesフィールドを削除し、OSS 公開方針を復元する。復元の理由
CONTRIBUTING.md L36「Node.js LTS 以降を推奨」の記述通り、starter は OSS 公開リポとして広いユーザー層への対応を優先するため、
enginesフィールドを意図的に未指定としている。e19a7a8 では
wp-starter(案件用リポ・開発環境を固定する意図的判断)との整合を理由にengines: { node: ">=24.0.0" }を追加したが、starter に同ポリシーを適用するのは誤判断であった。変更 diff
維持する変更
devDependencies.vite: "^8.0.5"— e19a7a8 のバージョン追従は有効なため維持検証
package.jsonJSON 構文 validenginesフィールド完全削除vite ^8.0.5維持確認pnpm run check通過pnpm run build成功(vite v8.0.10、74ms)🤖 Generated with Claude Code