fix: flaky listLmStudio nonzero-exit integration test#23
Merged
Conversation
added 2 commits
May 3, 2026 20:49
When lms exits nonzero, Promise.all rejects as soon as the ls call fails. The ps call (which has .catch) may or may not have written to the argv log yet — it's a race. Only assert that ls was called.
Committed to .hooks/pre-push and activated via git core.hooksPath in the prepare script. Anyone who clones and runs npm install gets the hook automatically — no Husky or extra dependencies needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent CI failure in
listLmStudio: nonzero exittest.The test asserted both
lsandpscalls were logged, butPromise.allrejects as soon aslsfails —ps(which has.catch()) may not have written to the argv log yet. Now only assertslswas called.Test plan
npm test— 88 pass (0 fail)