Add compound support to addAttribute function.#628
Merged
miquelcampos merged 5 commits intomgear-dev:masterfrom Mar 25, 2026
Merged
Add compound support to addAttribute function.#628miquelcampos merged 5 commits intomgear-dev:masterfrom
addAttribute function.#628miquelcampos merged 5 commits intomgear-dev:masterfrom
Conversation
Member
|
Hi @timothyliu3d Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
What?
Update
mgear.core.attribute.addAttributeto work with compound attributes (float2, long3, etc).Example usage:
Why?
I needed "float2" attribute types when using
ComponentGuide.addParam()for UV-related data. I figured extendingaddAttributewould be a better approach than making newaddVec2AttributeandVec2Paramjust for this purpose.Testing Done
Related Issue(s)
N/A