quickbuild.sh argument reg_grid or irreg_grid to select ROMS_rutgers model_mod

[hkershaw-brown]

Description:

ROMS_rutgers regular grid uses much less memory than the irregular grid (NCAR#1090)
However, ROMS has curvilinear and rotated grids. This pull request adds a compile time option (argument to quickbuild.sh)
to select regular or irregular grid.

regular grid model_mod_reg_grid (NCAR#1090)
irregular grid model_mod_irreg_grid (NCAR/DART v11.22)

Fixes issue

Extension of NCAR#1090

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Documentation changes needed?

• My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Just building

Checklist for merging

• Updated changelog entry
• Documentation updated
• Update conf.py

Checklist for release

• Merge into main
• Create release from the main branch with appropriate tag
• Delete feature-branch

Testing Datasets

• Dataset needed for testing available upon request
• Dataset download instructions included
• No dataset needed

[hkershaw-brown]

@mgharamti here is what I am thinking for a ROMS_rutgers (optimized reg-grid for Indonesia or other reg cases), but can switch in irregular grid version. Selection is done a quickbuild.sh time.

[mgharamti]

@hkershaw-brown, I was going to work on this today and you've already done it. Thank you. It looks good. I tested the code and it works. My only question is do we really need to call the resulting interface chosen_model_mod.f90? I was thinking to select one and copy it into model_mod.f90. This would make it consistent with other model interfaces. Thoughts!

[hkershaw-brown]

I gave it a different name "chosen_model_mod.f90" so I could ignore it in the global .gitinore.
I mostly did not want people adding it to git.
We could call it model_mod.f90 and it ignored with the path ROMS_rutgers/model.f90 (I think or a .gitignore in ROMS_rutgers

[mgharamti]

I think we should keep it as model_mod.f90
Regarding gitignore, are you worried that someone would commit the newly created file? Maybe I'm missing something but I still don't see why we need to add it to gitignore.

[hkershaw-brown]

Its an artifact of the build process, like obs_def_mod.f90 obs_kind_mod.f90 (or exectuables, *.mod, *o), so you don't want it showing as changed files in git.

[hkershaw-brown]

I'll go ahead and switch the name to model_mod.f90 and update the ignore files.

[hkershaw-brown]

oh nevermind, you already merged!